FIX: Don't notify on empty 'update's of Dict traits #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Oct 13, 2020
mdickinson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
TraitDict.updatemethod so that notifications are not issues when updating with an empty argument. This is similar to the behaviour of extending a list or updating a set with an empty argument.The PR also adds a test for the
TraitDict.clearmethod, to verify that it doesn't notify when clearing an already-empty dictionary.Fixes #1307
Checklist
Update API reference (Not neededdocs/source/traits_api_reference)Update User manual (Not neededdocs/source/traits_user_manual)Update type annotation hints inNot neededtraits-stubs