FIX: Add |= support to TraitDict for Python >= 3.9 #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you mean fixes #1016 ? |
Thank you, yes. No idea where I got that number from. Will fix. |
mdickinson
changed the title
| @@ -121,6 +122,51 @@ def test_delitem_not_found(self): | |||
| str(python_e.exception), | |||
| ) | |||
|
|
|||
| if sys.version_info >= (3, 9): | |||
There was a problem hiding this comment.
Would conditional skips of tests be better here?
There was a problem hiding this comment.
Possibly. I considered it, but right now we get a skip-free test run if all optional dependencies are installed, and I'd quite like to keep that property - it reassures me that all the tests have been run.
|
|
||
| retval = super().__ior__(validated_dict) | ||
|
|
||
| if added or changed: |
There was a problem hiding this comment.
There is a difference in behaviour here between this and update:
x.a |= {}
will not notify, but
x.a.update({})
does.
I would expect them to be consistent, and this may lead to issues in the future if people replace .update with |= and expect the same behaviour.
Edit: ah I see #1307.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
|=operations onTraitDict. In Python 3.9, those operations mutate the dictionary, but without corresponding support inTraitDict, that mutation will not emit a notification. This PR adds the missing notification.Fixes #1016.
Checklist
[ ] Update API reference (No update neededdocs/source/traits_api_reference)[ ] Update User manual (No update neededdocs/source/traits_user_manual)[ ] Update type annotation hints inNo stubs exist for TraitDict and friendstraits-stubs