Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding per-file-ignores to clean up noqa:F401 comments in api #1269

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

aaronayres35
Copy link
Contributor

@aaronayres35 aaronayres35 commented Aug 3, 2020

added a per-file-ignores line to https://github.com/enthought/traits/blob/master/setup.cfg to be able remove # noqa: F401 comments in https://github.com/enthought/traits/blob/master/traits/api.py

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson
Copy link
Member

LGTM2!

@aaronayres35 Please go ahead and merge once the CI completes.

@mdickinson
Copy link
Member

@aaronayres35 Just a general note: please do always include a description in PRs, even if it seems redundant to do so. It's really helpful to those coming back to the PR later to figure out what it did, and why.

@aaronayres35 aaronayres35 merged commit 6c46701 into master Aug 3, 2020
@aaronayres35 aaronayres35 deleted the fix-api-flake8 branch August 3, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants