Support resolve/update the source attachment for the binary classfile #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
|
Can one of the admins verify this patch? |
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
fbricon
reviewed
Oct 30, 2018
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/commands/SourceAttachmentCommand.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Oct 30, 2018
....jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/commands/SourceAttachmentCommandTest.java
Outdated
Show resolved
Hide resolved
|
@testforstephen can you also open a PR to expose that command on the vscode-java side? |
|
@fbricon Peer PR on vscode-java side. redhat-developer/vscode-java#699 |
|
Thanks @testforstephen, that should be helpful! |
|
@testforstephen can you please document the new command in the wiki? |
|
@fbricon should i add the new command in the vscode-java readme? right? |
|
@testforstephen yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
This PR is to fix bug redhat-developer/vscode-java#233 (Add ability to attach missing sources). It provides two comamnds: