Apply autobuilding setting when initializing.

[ethan-vanderheijden]

Fixes #3176

[eclipse-ls-bot]

Can one of the admins verify this patch?

[snjeza]

We disable auto building on

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/LanguageServerApplication.java

Line 79 in 3a8937a

private static void prepareWorkspace() throws CoreException {

Instead of adding this code, you can remove LanguageServerApplication.prepareWorkspace().
AFAICS, it doesn't affect performance.

[ethan-vanderheijden]

If I only remove LanguageServerApplication.prepareWorkspace(), then it is impossible to disable autobuild through initialization params. I'll still remove it because autobuild should be enabled by default unless configured otherwise.

[snjeza]

I'll still remove it because autobuild should be enabled by default unless configured otherwise.

Eclipse ResourcesPlugin remembers the workspace auto-build settings. See

• https://github.com/eclipse-platform/eclipse.platform/blob/8fe6bba1fe21e5cd255e5398596b5bc5e34f8342/resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/resources/ResourcesPlugin.java#L214
• https://github.com/eclipse-platform/eclipse.platform/blob/8fe6bba1fe21e5cd255e5398596b5bc5e34f8342/resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/PreferenceInitializer.java#L36

You are right. We have to call it if VS Code auto-build is off

[rgrunber]

Wait, @snjeza is this actually ok ? I remember we intentionally disabled autobuild during import to avoid import/build conflicts, #2252 .

Update: It was introduced in #469 (comment) . Another discussion at #2519 .

[snjeza]

Update: It was introduced in #469 (comment) . Another discussion at #2519 .

#2252 fixes it by interrupting the build. See

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java

Line 653 in 3a8937a

ws.getBuildManager().interrupt();

I think that we don't need to turn off auto-build anymore.
I have tried importing/reloading the quarkus-langchain4j and keycloak projects and didn't notice any performance degradation.

[rgrunber]

Ok, if that's the case then I think we can consider doing this. CC'ing @testforstephen given that this would impact #2519 .

[rgrunber]

Overall, the change looks fine. I just had one thought. @snjeza / @ethan-vanderheijden , would the syntax server now have the autobuild running as part of the steps leading up to the finishing of initialization (after that didChangeConfiguration is triggered which would set the autobuild back to its expected value) ?

Before this change the autobuild was turned off inLanguageServerApplication, which would have included both syntax & standard servers. With this change, the autobuild is only interrupted (turned off) by InitHandler, which is only the standard server's implementation. Is there any harm in this (having it on temporarily for the syntax server) ?

[snjeza]

Is there any harm in this (having it on temporarily for the syntax server) ?

Java LS sets the autobuilding to off for the syntax server. See

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JavaLanguageServerPlugin.java

Line 181 in e95ec63

ProjectsManager.setAutoBuilding(false);