Limit add missing imports on paste for source range #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
approved these changes
Feb 13, 2023
Signed-off-by: Shi Chen <chenshi@microsoft.com>
rgrunber
force-pushed
the
cs-issue2442
branch
from
32eaeb7 to
0da278b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shi Chen chenshi@microsoft.com
fix #2442, Now the additionalEdit is calculated from a fake ICompilationUnit with applying the incoming paste content, once the paste range is affecting current imports, there might be some overlap among insertText and additionalEdit.
With this PR we only do add missing imports on paste when the pasted range is within the original primary type's source range, so that we can guarantee that there is no overlap among insertText and additionalEdit.