For Unnamed Classes, generate the .class with the same name as the .java
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2024
jarthana
reviewed
Mar 6, 2024
datho7561
force-pushed
the
generate-classfile-with-same-name
branch
from
8f2aca6 to
38f99be
Compare
datho7561
force-pushed
the
generate-classfile-with-same-name
branch
from
67bcb4e to
466ad3e
Compare
|
I rewrote one of the tests because of eclipse-jdt#2156 (Completion fails when hiding enclosing type) |
datho7561
force-pushed
the
generate-classfile-with-same-name
branch
2 times, most recently
from
30626c5 to
37130ac
Compare
…`.java` - Provide and API to check if an IType is an implicitly declared class Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
generate-classfile-with-same-name
branch
from
37130ac to
bb49572
Compare
rgrunber
added a commit
to rgrunber/eclipse.jdt.ls
that referenced
this pull request
Mar 18, 2024
- See eclipse-jdtls/eclipse-jdt-core-incubator#102 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
added a commit
to eclipse-jdtls/eclipse.jdt.ls
that referenced
this pull request
Mar 18, 2024
- See eclipse-jdtls/eclipse-jdt-core-incubator#102 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
<unnamed_class$MyUnnamedClass>name is bad, because then the generated.classfile is invalid and can't be run.Current blocking problems:
ITypeis unnamed. In Do not show references for unnamed class eclipse.jdt.ls#3077 I am using the type name, but this will no longer work after this PR