Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip vllm-related tests on non-linux platforms #1357

Conversation

yvan-sraka
Copy link
Contributor

Fix #1356

@yvan-sraka yvan-sraka requested review from torymur and rlouf January 2, 2025 17:53
@yvan-sraka yvan-sraka self-assigned this Jan 2, 2025
@yvan-sraka yvan-sraka force-pushed the 1356-pytest-fails-in-a-fresh-environment-with-just-pip-install-test-dependencies branch 2 times, most recently from 5ebe662 to e13a791 Compare January 2, 2025 17:56
@yvan-sraka yvan-sraka force-pushed the 1356-pytest-fails-in-a-fresh-environment-with-just-pip-install-test-dependencies branch from e13a791 to 205f51c Compare January 2, 2025 17:57
@rlouf
Copy link
Member

rlouf commented Jan 2, 2025

LGTM!

Copy link
Contributor

@torymur torymur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rlouf rlouf marked this pull request as ready for review January 3, 2025 11:37
@rlouf rlouf merged commit d32dfde into main Jan 3, 2025
7 checks passed
@rlouf rlouf deleted the 1356-pytest-fails-in-a-fresh-environment-with-just-pip-install-test-dependencies branch January 3, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest fails in a fresh environment with just pip install ".[test]" dependencies
3 participants