-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-staging] [mono] Disable UnitTest_GVM_TypeLoadException for fullAOT jobs #111394
Merged
matouskozak
merged 1 commit into
release/9.0-staging
from
backport/pr-107502-to-release/9.0-staging
Jan 21, 2025
Merged
[release/9.0-staging] [mono] Disable UnitTest_GVM_TypeLoadException for fullAOT jobs #111394
matouskozak
merged 1 commit into
release/9.0-staging
from
backport/pr-107502-to-release/9.0-staging
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @akoeplinger, @matouskozak |
/azp run runtime-llvm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
vitek-karas
approved these changes
Jan 15, 2025
jeffschwMSFT
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can consider this tell mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107502 to release/9.0-staging
/cc @matouskozak
Disable UnitTest_GVM_TypeLoadException for fullAOT Mono jobs
Customer Impact
CI only change.
Regression
The regression was introduce by #107409.
Testing
The failure wasn't caught on
runtime
pipeline because Mono FullAOT jobs are only run as part ofruntime-extra-platforms
orruntime-llvm
.Risk
Low: disabling unsupported failing test scenario to keep CI green.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging
, notrelease/X.0
.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.