fix(FTM): future contentlet image not updating correctly #31590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updating-correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of URLs and the Time Machine feature in the dotCMS platform. The most important changes involve modifications to the
withEditor.tsfile to ensure safe access to store parameters, and updates to thePageResource.javaandShortyServlet.javafiles to enhance the Time Machine functionality.URL Handling Improvements:
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts: Updated thewithEditorfunction to use theuntrackedutility for accessing store parameters, ensuring that the parameters are not tracked by the reactive system.Time Machine Enhancements:
dotCMS/src/main/java/com/dotcms/rest/api/v1/page/PageResource.java: Modified thegetPageRendermethod to remove the reset of the Time Machine in thefinallyblock, and updated thesetUpTimeMachineIfPresentmethod to reset the Time Machine if not needed. [1] [2] [3]dotCMS/src/main/java/com/dotmarketing/servlets/ShortyServlet.java: Added thegetTimeMachineContentletmethod to retrieve future versions of contentlets if a Time Machine date is configured, and updated thegetContentletByIdentifiermethod to use this new method. [1] [2]