Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate app to using github.com/slack-go/slack #58

Merged
merged 12 commits into from
Mar 17, 2025

Conversation

DXTimer
Copy link
Contributor

@DXTimer DXTimer commented Mar 14, 2025

The Slack client we have been relying on has been deprecated since 2021. This PR adopts the official Slack go client.

I have also taken the opportunity to update our documentation.

Belongs to https://github.com/dnsimple/dnsimple-engineering/issues/271

@DXTimer DXTimer added task dependencies Pull requests that update a dependency file. labels Mar 14, 2025
@DXTimer DXTimer self-assigned this Mar 14, 2025
@DXTimer DXTimer requested a review from a team March 14, 2025 06:53
@DXTimer DXTimer force-pushed the task/migrate-slack-client branch from 7d46e68 to 80832b8 Compare March 14, 2025 06:57
Copy link
Member

@san983 san983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @DXTimer!

I've just run go get -u && go mod tidy in order to update the deps since it was still calling the one you're removing

Base automatically changed from task/upgrade-go/1-24-1 to main March 17, 2025 08:55
@DXTimer DXTimer merged commit c07559d into main Mar 17, 2025
5 checks passed
@DXTimer DXTimer deleted the task/migrate-slack-client branch March 17, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants