fix(ChannelUpdateAction): emit client event in handle to not miss change

[Apokalypt]

Please describe the changes this PR makes and why it should be merged:
This PR corrects the bug reported in #10658 by moving the emission of events inside the action so that no changes are zapped.
Currently, the <ChannelUpdateAction>.handle method is called within the ThreadChannel and GuildChannelManager classes. This call could result in a modification to the cached instance before the event was received from Discord, causing the event to be lost with the actual modification.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)	Visit Preview		Jan 4, 2025 11:34pm
discord-js-guide	⬜️ Ignored (Inspect)	Visit Preview		Jan 4, 2025 11:34pm

[SpaceEEC]

Wouldn't this change cause the update events to be emitted twice when first calling the action from within edit and then from the WebSocket handler?

[Apokalypt]

Wouldn't this change cause the update events to be emitted twice when first calling the action from within edit and then from the WebSocket handler?

It will, exactly like the method <Guild>.edit()

In my opinion, it's better to receive two events (one with old/new channels with the same data) than to lose the real modification. On the other hand, I agree with you that it's not ideal and that we should perhaps think about a better solution in general, as other events are subject to the same behavior.