Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Better application command mention format approach #10639

Merged
merged 2 commits into from
Jan 12, 2025

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Dec 5, 2024

Please describe the changes this PR makes and why it should be merged:
This function is handled strangely—the command id is always the last parameter, the command id is possibly undefined, etc.

This approach makes the function more understandable. For example, the id is always required, so that is the first parameter and is not possibly undefined.

I am not sure if we still want all the overloads now. Also open to using an object approach.

Fixes DJS-55

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

BREAKING CHANGE: The parameters of `chatInputApplicationCommandMention()` have been reordered.
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 8:04pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 8:04pm

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.16%. Comparing base (91f59cf) to head (0d850e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10639      +/-   ##
==========================================
- Coverage   37.97%   37.16%   -0.82%     
==========================================
  Files         239      239              
  Lines       14872    15122     +250     
  Branches     1377     1370       -7     
==========================================
- Hits         5648     5620      -28     
- Misses       9213     9491     +278     
  Partials       11       11              
Flag Coverage Δ
formatters 99.63% <100.00%> (ø)
utilities 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite merged commit 3ddb732 into main Jan 12, 2025
25 checks passed
@Jiralite Jiralite deleted the refactor/better-command-mention branch January 12, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants