Parse Hex #684
Merged
Parse Hex #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandowns
reviewed
Oct 24, 2023
| error(parser, "\\x escape code expects format \\xhh"); | ||
| break; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we add an additional check here to make sure the given characters are in fact valid hex (0123456789abcdefABCDEF)?
There was a problem hiding this comment.
That should happen below in the strtol check, but potentially an easier check is checking for the char being in that range
There was a problem hiding this comment.
Oh my bad, I just noticed that now. I'll defer to you. :)
There was a problem hiding this comment.
No worries! Thanks for double checking anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse Hex
What's Changed:
Ability to parse hex codes
Type of Change:
Housekeeping:
Screenshots (If Applicable):