Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class to dict #656

Merged
merged 7 commits into from
Sep 8, 2023
Merged

Class to dict #656

merged 7 commits into from
Sep 8, 2023

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Sep 6, 2023

Resolves: #

What's Changed:

Adds the ability to convert a class to a dictionary.

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns
Copy link
Contributor Author

I see the error messages but kinda at a loss as this is passing locally with no issue.

@Jason2605
Copy link
Member

Pushed up a couple of changes there:

  • Walk the full inheritance chain rather than just one parent up
  • Fix a couple of memory issues where the strings weren't being pushed and the dicts/lists were being popped too early
  • Add a test case for inheritance

@briandowns
Copy link
Contributor Author

Thanks. I'll get this one of these days.

@Jason2605
Copy link
Member

Hahaha yeah 4 years down the line I'm still wrapping my head around it! Thanks for this

@Jason2605 Jason2605 merged commit 44b8ed6 into dictu-lang:develop Sep 8, 2023
This was referenced Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants