Win32 fixes #597
Merged
Win32 fixes #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I have a pretty busy week this week but will try my best to get round to them at the weekend, sorry! |
|
Just as a quick check, did you replace the linenoise files completely? Just as the linenoise file within Dictu does have a couple of custom additions to it |
|
Yes, I replaced it with a different fork. I did not notice any problems at compile-time but if you can tell me what custom additions you made, I can look into it. |
|
Actually sorry ignore me I'm talking rubbish, this looks great thank you very much! |
Jason2605
added a commit
that referenced
this pull request
Feb 16, 2023
Removed option to build without linenoise (depends on #597)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well detailed description of the change :
Corrected some errors in compilation for Win32. Ability to compile Win32 version on Linux using MinGW.
Modified linenoise with support for Win32 and additional features not available in the currently included linenoise (Such as Ctrl-R history search).
Type of change: