-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add structured logger example app #501
add structured logger example app #501
Conversation
Signed-off-by: Brian Downs <brian.downs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massively nitpick comments really (sorry) but just a few changes!
I really like this example though, thanks!
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Hm interestingly the CI/CD is exiting with 1. Not entirely sure why, it doesn't for me locally... |
Strange. it's doing the same for me as well. (macOS) |
Hm. I'm on MacOS as well and it seems to exit as normal.. |
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@Jason2605 Looks like it was the exit call at the end of the example. Good to go. |
Thats made me a little uneasy haha. I tested locally and on an ubuntu VM and it didn't seem to exit with code 1. An exit(0) call also shouldn't have made it exit with code 1 🤯 |
Ahhh I know why it's giving exit code 1. The CI/CD is expecting the debug message "Total bytes lost: 0" but the Given that I'm happy with this PR, thank you! |
Signed-off-by: Brian Downs brian.downs@gmail.com
Well detailed description of the change :
Adds a simple JSON structured logger.
Resolves: #
Type of change:
Bug fix
New feature
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Housekeeping
Tests have been updated to reflect the changes done within this PR (if applicable).
Documentation has been updated to reflect the changes done within this PR (if applicable).
Preview (Screenshots) :