Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Import for System module #460

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Conversation

Jason2605
Copy link
Member

Well detailed description of the change :

This PR makes it so that the System module will now require an import.

Context of the change :

This change was done as all other stdlib modules require an import whereas System currently doesn't. This doesn't really make much sense and may cause issues (and certainly confusion) to users who are attempting to use the module / incorrectly import it.

Resolves: #456

Type of change :

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Jason2605 Jason2605 added the enhancement Implementation of a new feature label Oct 5, 2021
@Jason2605 Jason2605 self-assigned this Oct 5, 2021
@Jason2605 Jason2605 merged commit fa6a0d1 into develop Oct 8, 2021
@Jason2605 Jason2605 deleted the feature/system_module branch October 8, 2021 19:12
@Jason2605 Jason2605 mentioned this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Implementation of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make the System module require an import
1 participant