fix: finish TLS handshake before shutting down #14547
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
requested review from
bartlomieju,
crowlKats,
lucacasonato and
littledivy
as code owners
This commit ensures that the TLS handshake completes before attempting to close the connection.
lucacasonato
approved these changes
May 9, 2022
bartlomieju
approved these changes
May 10, 2022
piscisaureus
pushed a commit
that referenced
this pull request
May 12, 2022
This commit ensures that the TLS handshake completes before attempting to close the connection.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the TLS handshake completes before
attempting to close the connection.
Fixes: #14494
This fixes the bug in the linked issue, but creating a reproducible unit test has been... frustrating.