Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Bind port numbers in Helm values file #1194

Merged
merged 1 commit into from
May 10, 2023

Conversation

Sgitario
Copy link
Collaborator

The port number should be inline in several locations: deployment resources, service and HTTP probes.

@Sgitario Sgitario requested a review from iocanel May 10, 2023 11:51
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The port number should be inline in several locations: deployment resources, service and HTTP probes.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sgitario Sgitario merged commit 8f05e87 into dekorateio:main May 10, 2023
@Sgitario Sgitario deleted the helm_bind_ports branch May 10, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants