Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow down polling of ParameterPolling KIA / Hyundai #734

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

LevinSwe
Copy link
Contributor

@LevinSwe LevinSwe commented Jan 2, 2025

What

Slow down ParameterPolling of Kia / Hyundai battery

Why

Sometimes the CellVoltages are corrupted due to high CAN-load / CPU load

How

Polling of Parameter ID's polled every other time instead of each 100ms cycle.

- Expand the time of parameterID polling to increase the ID-counter every other time instead of every 100ms cycle.
- Sometimes the cell voltages are corrupted if polled to fast.
@dalathegreat dalathegreat linked an issue Jan 2, 2025 that may be closed by this pull request
- Removed Non-used parameter polling IDs 7 -- 10
- Moved the PID counter Max value code inside the if (hold counter) code.
@mvgalen mvgalen self-requested a review January 2, 2025 20:41
Copy link
Collaborator

@mvgalen mvgalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mvgalen mvgalen requested a review from dalathegreat January 2, 2025 20:41
@dalathegreat dalathegreat merged commit e0d72b7 into dalathegreat:main Jan 2, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyundai kona ev cell monitoring issue
3 participants