Move check if CAN_ADDON AND CANFD_ADDON are defined simultaneously, to respective hardware #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR moves the check if
CAN_ADDONandCANFD_ADDONare defined simultaneously, to throw an error if these functions use the same hardware pins, only to the hardware where these pins overlap (i.e. LilyGo).Why
To ensure that the respective error message is only triggered for the hardware that it needs to trigger for.
How
By moving the check from
include.htohw_liligo.h, as this check is only relevant for LilyGo hardware.