Adding feature to log to SD Card #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No-Signal
force-pushed
the
feature/Log_To_SDCard
branch
from
241f3cb to
362cab7
Compare
No-Signal
force-pushed
the
feature/Log_To_SDCard
branch
from
362cab7 to
e2eae8f
Compare
- Improve performance by removing unnecessary copies. - Refactor code to remove duplication of time printing code.
- Improve performance by removing unnecessary copies. - Refactor code to remove duplication of time printing code.
- Timestring needs to be one larger to fit string + NULL character - snprintf and friends return the amount of bytes that would have been written (if the buffer was large enough), not the actual number of bytes, therefore take the minimum of both values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements logging messages to an SD Card where available
Why
This will help to diagnose issues when an emulator reboots as the log is persisted
How
This is an extension to the sdcard methods to add a second buffer for logs which are sent from the logger and written to the SD Card on the second CPU core