fix comparing content for a "simple" field that already has an empty value #1621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you’re importing into a feed with
setEmptyValues
turned on,compareContent
set to true (default), you have an existing element with a field that’s already empty, and you’re importing an empty value into that field, the content comparison was incorrectly reporting that the content has changed.This happened because the
Hash::check
will always returnfalse
if the key exists but the value isnull
, causing the content to never actually get compared.(
Hash::extract
will return an empty array causingHash::check
to return false.)Related issues
#1615