Fixed a bug where variants would not save #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where the nested variant element manager used different attribute names (`allVariants` & `variants`) across different versions of 5.x Setting all as dirty ensures it saves the variants in the nested element manager regardless of the attribute name used.
|
@lukeholder, I was able to reproduce the problem and verified that with this PR the variants are saving as expected. |
|
Just released Feed Me 6.8.0 with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where the nested variant element manager used different attribute names (
allVariants&variants) across different versions of 5.xSetting as 'all dirty' ensures it saves the variants in the nested element manager regardless of the attribute name used.