CodeMirror 6 / beta editor support #93
Merged
+4,186
−11,176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alondmnt
commented
Mar 28, 2024
alondmnt
commented
- Tested on desktop
- Tested on mobile
src/codeMirror6Scroller.ts
Outdated
Comment on lines
7
to
29
| plugin: (editorControl: any) => { | ||
| if (!editorControl.cm6) { return; } | ||
|
|
||
| // Running in CM6 | ||
| editorControl.registerCommand('scrollToLine', (lineNumber: number) => { | ||
| const editor: EditorView = editorControl.editor; | ||
| console.log('scrollToLine', lineNumber); | ||
|
|
||
| // Bounds checking | ||
| if (lineNumber < 0) { | ||
| lineNumber = 0; | ||
| } | ||
| if (lineNumber > editor.state.doc.lines) { | ||
| lineNumber = editor.state.doc.lines; | ||
| } | ||
|
|
||
| // Scroll to line, place the line at the *top* of the editor | ||
| const lineInfo = editor.state.doc.line(lineNumber); | ||
| editor.dispatch(editor.state.update({ | ||
| effects: EditorView.scrollIntoView(lineInfo.from, {y: 'start'}) | ||
| })); | ||
| }); | ||
| }, |
There was a problem hiding this comment.
@alondmnt This currently uses mixed tabs and space indentation.
(Thank you for working on this!)
Also note that if upgrading the plugin API proves to be too big of a change for this pull request, it should be possible to require CodeMirror 6 modules (with no types) with joplin.require. For example,
const { EditorView } = joplin.require('@codemirror/view');
There was a problem hiding this comment.
Thanks, missed those tabs (fixed).
Also accidentally installed @codemirror/view not as a dev dependency (fixed).
As for the joplin.require trick (thanks!), I had an issue with it so left it as is for now. If you or cqroot feel that this is necessary will try to resolve it.
refactor: fix eslint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.