Skip to content

WIP: Fix/599 js yaml cosmiconfig #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Conversation

escapedcat
Copy link
Member

Trying to update cosmiconfig. But failing.

Getting this for all tests:

  Rejected promise returned by test. Reason:

  Error {
    code: 'EISDIR',
    errno: -21,
    syscall: 'read',
    message: 'EISDIR: illegal operation on a directory, read',
  }

I played around with it and tried other options. I'm lost...

Description

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {

};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@byCedric byCedric self-requested a review March 28, 2019 21:57
@marionebl marionebl merged commit f186fcb into master Mar 28, 2019
@marionebl marionebl deleted the fix/599_js-yaml-cosmiconfig branch June 1, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants