Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectLeaders api(KIP-460) implemented #1818

Merged
merged 14 commits into from
Oct 9, 2024
Merged

ElectLeaders api(KIP-460) implemented #1818

merged 14 commits into from
Oct 9, 2024

Conversation

PratRanj07
Copy link
Contributor

Implemented Elect Leaders API and added unit tests for it.

@PratRanj07 PratRanj07 requested review from a team as code owners September 20, 2024 13:08
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@PratRanj07 PratRanj07 reopened this Oct 3, 2024
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the major comment. Still reviewing other files.

@PratRanj07 PratRanj07 requested a review from pranavrth October 9, 2024 20:00
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly nits.

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of more nits. Otherwise looks good.

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pratyush!. LGTM!

@PratRanj07 PratRanj07 merged commit 6642180 into master Oct 9, 2024
2 of 3 checks passed
@PratRanj07 PratRanj07 deleted the dev_electLeaders branch October 9, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants