Skip to content

completed #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

completed #52

wants to merge 1 commit into from

Conversation

remykung
Copy link
Collaborator

Change Summary

create the add function

Change Form

create the add function

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

@remykung remykung requested a review from NicholasChoong June 24, 2023 07:02
@remykung remykung linked an issue Jun 24, 2023 that may be closed by this pull request
Add logic to the addition function 30 #32
Open
@APM246 APM246 self-requested a review June 24, 2023 07:03
APM246
APM246 requested changes Jun 24, 2023
View reviewed changes
Copy link

@APM246 APM246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve however the title of this PR needs to be more descriptive

dct0
dct0 approved these changes Jun 24, 2023
View reviewed changes
Copy link

@dct0 dct0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

NicholasChoong
NicholasChoong approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@NicholasChoong NicholasChoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@NicholasChoong
Copy link
Member

Definitely change the title to something that describes what the feature change is :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APM246 APM246 APM246 requested changes

@dct0 dct0 dct0 approved these changes

@NicholasChoong NicholasChoong NicholasChoong approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logic to the addition function 30
4 participants
@remykung @NicholasChoong @dct0 @APM246