Skip to content

Resolve potential OOM (Out-Of-Memory) issues in the Spine runtime for web platforms. #18610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 17, 2025

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Apr 14, 2025

Re: #
cocos/cocos-test-projects#916
https://forum.cocos.org/t/topic/166062
cocos/cocos-engine-external#485

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from dumganhar April 14, 2025 07:03
@bofeng-song bofeng-song reopened this Apr 15, 2025
@dumganhar
Copy link
Contributor

@cocos-robot run test cases

Copy link

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1006139 bytes 1006139 bytes ✅ 0 bytes
2D All (legacy pipeline) 2668665 bytes 2669478 bytes ⚠️ +813 bytes
2D All (new pipeline) 2756873 bytes 2757686 bytes ⚠️ +813 bytes
(2D + 3D) All 10010462 bytes 10011275 bytes ⚠️ +813 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16924878 bytes 16927398 bytes ⚠️ +2520 bytes

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -53368,9 +53368,8 @@
             protected _animationQueue: __private._cocos_spine_skeleton__AnimationItem[];
             protected _headAniInfo: __private._cocos_spine_skeleton__AnimationItem | null;
             protected _isAniComplete: boolean;
             protected _playTimes: number;
-            protected _needUpdateSkeltonData: boolean;
             protected _listener: __private._cocos_spine_track_entry_listeners__TrackEntryListeners | null;
             _vLength: number;
             _vBuffer: Uint8Array | null;
             _iLength: number;

Copy link

@bofeng-song, Please check the result of run test cases:

Task Details

Copy link

@bofeng-song, Please check the result of run test cases:

Task Details

@dumganhar dumganhar merged commit a6c5ce0 into cocos:v3.8.7 Apr 17, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants