-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update terraform cloudposse/ec2-instance/aws to v1.6.1 #3
base: main
Are you sure you want to change the base?
Conversation
/terratest |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟠 Require terratestWaiting checks:
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
This PR contains the following updates:
1.4.0
->1.6.1
Release Notes
cloudposse/terraform-aws-ec2-instance (cloudposse/ec2-instance/aws)
v1.6.1
Compare Source
fix: allow stopping instance before detachment and/or forced ebs detachments @Hamza-Olol (#212)
Added support to the EBS volume attachment resource for the `force_detach` and `stop_instance_before_detaching` arguments.These changes allow users to:
- Force the detachment of EBS volumes.
- Stop instances before detaching volumes, ensuring smooth resource teardown during Terraform destroy operations.
why
I cannot delete my Terraform resources using a standard Terraform destroy because I have attached additional ebs volumes to my instance and then ran disk configuration changes in my instance, for example, combined multiple ebs volumes into a striped disk config.
Business use cases may require additional EBS volumes, along with specific disk configurations for the volumes attached to EC2 instances.
When attempting to delete resources via Terraform, the destroy process fails due to issues with EBS volume attachments. These issues include timeouts or the inability to delete volumes because they are in a "busy" state.
The problem arises because Terraform attempts to detach EBS volumes before deleting/stopping the EC2 instance, leading to failures if the volume cannot be detached.
To address this, Terraform introduced the
force_detach
andstop_instance_before_detaching
arguments, which allows forced detachment and/or stopping of the instance prior to detaching volumes. These enhancements mitigate the destroy-time failures and ensure smoother resource cleanup.references
The
force_detach
andstop_instance_before_detaching
arguments were introduced in Terraform AWS provider version v3.62.0.Additional details and discussion about this issue can be found in this GitHub thread.
🤖 Automatic Updates
Migrate new test account @osterman (#210)
what
.github/settings.yml
.github/chatops.yml
fileswhy
.github/settings.yml
from org level to getterratest
environmenttest
accountReferences
Update .github/settings.yml @osterman (#207)
what
.github/settings.yml
.github/auto-release.yml
fileswhy
.github/settings.yml
from org levelreferences
Update .github/settings.yml @osterman (#206)
what
.github/settings.yml
.github/auto-release.yml
fileswhy
.github/settings.yml
from org levelreferences
v1.6.0
Compare Source
fix: remove lifecycle ignore changes for ami argument @nitrocode (#205)
what
why
references
v1.5.0
Compare Source
feat: Add missed tags @MaxymVlasov (#204)
what
Add tags to resources where they missed
🤖 Automatic Updates
Update .github/settings.yml @osterman (#201)
what
.github/settings.yml
.github/auto-release.yml
fileswhy
.github/settings.yml
from org levelreferences
Update release workflow to allow pull-requests: write @osterman (#199)
what
.github/workflows/release.yaml
) to have permission to comment on PRwhy
Update GitHub Workflows to use shared workflows from '.github' repo @osterman (#198)
what
.github/workflows
) to use shared workflows from.github
repowhy
v1.4.1
Compare Source
feat: disable_api_stop option @flightlesstux (#197)
what
Control your EC2 Disable API with your Terraform
why
Because, AWS SDK and cli are supporting.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#disable_api_stop
🤖 Automatic Updates
Update GitHub Workflows to Fix ReviewDog TFLint Action @osterman (#196)
what
.github/workflows
) to addissue: write
permission needed by ReviewDogtflint
actionwhy
Update GitHub workflows @osterman (#195)
what
.github/workflows/settings.yaml
)why
Use GitHub Action Workflows from `cloudposse/.github` Repo @osterman (#192)
what
why
cldouposse/.github
repositoryConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.