feat(core): Log runtime names during Server shutdown #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log the names of runtimes during Server shutdown. Motivation: server shutdown can take quite a long time if the runtimes don't exit. It's hard to debug why this is the case, because there is no indiciation in the logs which service is pending. This small change modifies the server to log the name of the service whose runtime is being waited for.
theduke
force-pushed
the
server-log-runtime-names-during-shutdown
branch
from
be31479 to
278730c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the names of runtimes during Server shutdown.
Motivation: server shutdown can take quite a long time if the runtimes
don't exit.
It's hard to debug why this is the case, because there is no indiciation
in the logs which service is pending.
Same goes for shutdown failures.
This small change modifies the server to log the name of the service
whose runtime is being waited for.