feat: Enable tracking the execution phase of a server #511
+238
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
force-pushed
the
server-phase-monitor
branch
2 times, most recently
from
521b794 to
e334612
Compare
Adds a way for subcribers to track the execution phase of a Server. The new method `Server::watch_execution_phase` returns a broadcast channel that will receive ExecutionPhase messages on each phase transition. Example use cases: * A /health endpoint that reports the current execution phase (only interesting for shutdown) * Producing metrics for the various phase transitions
theduke
force-pushed
the
server-phase-monitor
branch
from
e334612 to
3b7b3dd
Compare
theduke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way for subcribers to track the execution phase of a Server.
The new method
Server::watch_execution_phasereturns a broadcastchannel that will receive ExecutionPhase messages on each phase transition.
Example use cases:
(only interesting for shutdown)
Note: This PR pairs nicely with #493
I'm happy for that to be merged first and then rebase.
If the change is acceptable, that is.