feat(cache): Allow using in-memory compression dicts #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
force-pushed
the
cache-compression-set-from-memory
branch
from
85075f9 to
6cfe7e4
Compare
This PR allows setting the compression dictionary used for headers in `pingora-cache` from in-memory bytes instead of an external file. This is useful if the dict is already embedded in the binary, or is retrieved from remote storage dynamically. Also cleans up the code a bit by making the constant private, moving the initialisers to the same file and re-exporting them to keep the logic contained, and by slightly simplifying the file loading code.
theduke
force-pushed
the
cache-compression-set-from-memory
branch
from
6cfe7e4 to
e7c01ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting the compression dictionary used for headers in
pingora-cachefrom in-memory bytes instead of an external file through a newset_compression_dict_contentfunction.This is useful if the dict is already embedded in the binary, or is
retrieved from remote storage dynamically.
Also cleans up the code a bit by making the static private, moving the
initialisers to the same file and re-exporting them to keep the logic
contained, and by slightly simplifying the file loading code.
There is a small ordering change: the file now needs to be available at the time
set_compression_dict_path()is called, rather than at the timeHEADER_SERDEis first accessed, but that shouldn't cause any issues?