fix: add generics to Binding type
#604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adtennant
force-pushed
the
main
branch
4 times, most recently
from
042546c to
4c81cd4
Compare
Signed-off-by: Alex Tennant <atennant@skedulo.com> Fixes: cloudevents#487 Signed-off-by: Alex Tennant <atennant@skedulo.com>
lholmquist
approved these changes
Apr 2, 2025
|
@adtennant Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Bindingtype so that the typings of the values returned bybinaryandstructuredcan be more exact.KafkaMessageso thatTis authoritative of the type ofvalue.Fixes: #487
Description
The typing changes are not perfect, but they are closer to reality and backward compatible. They should remove a decent chunk of
ascasting in client code.