Make a copy of configuration being passed in #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiojose
reviewed
Jun 11, 2019
| @@ -1,7 +1,7 @@ | |||
| var axios = require("axios"); | |||
|
|
|||
| function HTTPBinary(configuration){ | |||
| this.config = configuration; | |||
| this.config = JSON.parse(JSON.stringify(configuration)); | |||
There was a problem hiding this comment.
Please check out the line #14. I suggest you remove this copy because it is useless.
There was a problem hiding this comment.
I saw line #14. I don't think it's useless because the config object is being changed in line 6/7. That's what is causing npm test to fail...
There was a problem hiding this comment.
It might make more sense if you look at my other pull request first. #15
fabiojose
reviewed
Jun 11, 2019
| @@ -2,7 +2,7 @@ var axios = require("axios"); | |||
| var empty = require("is-empty"); | |||
|
|
|||
| function HTTPBinary(configuration){ | |||
| this.config = configuration; | |||
| this.config = JSON.parse(JSON.stringify(configuration)); | |||
There was a problem hiding this comment.
Check out the line #15. The same way.
fabiojose
reviewed
Jun 11, 2019
| @@ -1,7 +1,7 @@ | |||
| var axios = require("axios"); | |||
|
|
|||
| function HTTPStructured(configuration){ | |||
| this.config = configuration; | |||
| this.config = JSON.parse(JSON.stringify(configuration)); | |||
There was a problem hiding this comment.
Check out the line #14. Same suggestion.
fabiojose
reviewed
Jun 11, 2019
| @@ -1,7 +1,7 @@ | |||
| var axios = require("axios"); | |||
|
|
|||
| function HTTPStructured(configuration){ | |||
| this.config = configuration; | |||
| this.config = JSON.parse(JSON.stringify(configuration)); | |||
|
@playground-julia I've made some suggestions. Looking forward to your comments. |
ghost
mentioned this pull request
|
Putting these changes in PR #15 and closing this. This was also not signed. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests currently do not pass because the same config object is being used between the two bindings and the Content Type is being overridden. Changing the constructor to copy the config fixes this problem.