Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tetragon: Add documentation for Signal and NoPost actions #948

Merged
merged 1 commit into from
Apr 24, 2023
Merged

tetragon: Add documentation for Signal and NoPost actions #948

merged 1 commit into from
Apr 24, 2023

Conversation

olsajiri
Copy link
Contributor

Adding documentation for Signal and NoPost actions.

@olsajiri olsajiri marked this pull request as ready for review April 21, 2023 11:57
@olsajiri olsajiri requested a review from a team as a code owner April 21, 2023 11:57
@olsajiri olsajiri requested a review from jrfastab April 21, 2023 11:57
@netlify
Copy link

netlify bot commented Apr 21, 2023 •
edited
Loading

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit c2f78ce
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/64464d4d449e1c00075f25c7
😎 Deploy Preview https://deploy-preview-948--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@olsajiri olsajiri requested review from kkourt and tixxdz April 21, 2023 11:58
tixxdz
tixxdz approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated @olsajiri and let's hope we'll have sig* string support soon hehe ;-)

@mtardy mtardy added the area/documentation Improvements or additions to documentation label Apr 24, 2023
mtardy
mtardy approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit but thank you for that feature and that's really great that we got documentation about it also :)

docs/content/en/docs/reference/tracing-policy.md Outdated
##### Signal action

`Signal` action sends specified signal to current process. The signal number
is specified with argSig value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is specified with argSig value.
is specified with `argSig` value.

docs/content/en/docs/reference/tracing-policy.md Outdated
is specified with argSig value.

Following example is equivalent to the Sigkill action example above.
The difference is to use the signal action with SIGKILL(9) signal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The difference is to use the signal action with SIGKILL(9) signal.
The difference is to use the signal action with `SIGKILL(9)` signal.

@olsajiri
tetragon: Add documentation for Signal and NoPost actions
c2f78ce 
Adding documentation for Signal and NoPost actions.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@mtardy
Copy link
Member

mtardy commented Apr 24, 2023

Thanks a lot let's 🚢

@mtardy mtardy merged commit 025074b into cilium:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tixxdz tixxdz tixxdz approved these changes

@mtardy mtardy mtardy approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab jrfastab is a code owner automatically assigned from cilium/tetragon

@kkourt kkourt Awaiting requested review from kkourt

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olsajiri @mtardy @tixxdz