Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add location addresses data from Romania #1046

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

Sibor2000
Copy link
Contributor

I have added locations for Romania, following the style of Portugal and Poland

@cieslarmichal cieslarmichal linked an issue Feb 12, 2025 that may be closed by this pull request
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but you need to also add them into location.cpp and location_test.cpp as other countries

@Sibor2000
Copy link
Contributor Author

Made the changes. However, I don't know what that ubuntu bazel fail is.

@cieslarmichal
Copy link
Owner

Dont worry about bazel its good

@cieslarmichal cieslarmichal merged commit a196590 into cieslarmichal:main Feb 12, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add location addresses data from Romania
2 participants