Skip to content

Support spanGaps in radar charts #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Support spanGaps in radar charts #6289

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e20e49
Support spanGaps in radar charts
nagix May 21, 2019
ddf00d0
Minor fixes based on feedback
nagix May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Minor fixes based on feedback
  • Loading branch information
@nagix
nagix committed May 22, 2019
commit ddf00d0fa9f7af7d6a8a3e97603704893b62e009
6 changes: 3 additions & 3 deletions src/controllers/controller.radar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ module.exports = DatasetController.extend({
*/
_resolveDatasetElementOptions: function() {
var me = this;
var datasetOpts = me._config;
var config = me._config;
var options = me.chart.options;
var values = DatasetController.prototype._resolveDatasetElementOptions.apply(me, arguments);

values.spanGaps = valueOrDefault(datasetOpts.spanGaps, options.spanGaps);
values.tension = valueOrDefault(datasetOpts.lineTension, options.elements.line.tension);
values.spanGaps = valueOrDefault(config.spanGaps, options.spanGaps);
values.tension = valueOrDefault(config.lineTension, options.elements.line.tension);

return values;
},
Expand Down