Xdg variables (5.21-candidate) #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should handle latest-candidate as well as X.YZ-edge Signed-off-by: Simon Deziel <simon.deziel@canonical.com> (cherry picked from commit d55c0f0)
`lxc config edit` would generate some noise if `/root/.local` didn't exist: ``` Unable to create directory /root/.local/share//nano/: No such file or directory It is required for saving/loading search history or cursor positions. ``` Normally, `nano` would create the hiearchy `/root/.local/share/nano/` itself if XDG_DATA_HOME is not defined. This hiearchy creation logic is skipped if the variable is defined. The spec [1] contains this: > If $XDG_DATA_HOME is either not set or empty, a default equal to $HOME/.local/share should be used. > If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used. > If $XDG_STATE_HOME is either not set or empty, a default equal to $HOME/.local/state should be used. So let's not export those as `nano` knows about those defaults and can then create the proper directories without warnings. [1]: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html#variables Signed-off-by: Simon Deziel <simon.deziel@canonical.com> (cherry picked from commit 7dcb188)
The spec [1] contains this: > If $XDG_DATA_HOME is either not set or empty, a default equal to $HOME/.local/share should be used. > If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used. > If $XDG_STATE_HOME is either not set or empty, a default equal to $HOME/.local/state should be used. So let's not export those since applications should simply rely on the default/empty. Exporting those without any corresponding directory caused issue with `nano` as can be seen in the previous commit. Also, on a "normal" desktop environment, none of XDG_DATA_HOME, XDG_CONFIG_HOME and XDG_STATE_HOME are exported: ``` $ env | grep ^XDG_ XDG_CONFIG_DIRS=/etc/xdg/xdg-ubuntu:/etc/xdg XDG_MENU_PREFIX=gnome- XDG_SESSION_DESKTOP=ubuntu XDG_SESSION_TYPE=wayland XDG_CURRENT_DESKTOP=ubuntu:GNOME XDG_SESSION_CLASS=user XDG_RUNTIME_DIR=/run/user/1000 XDG_DATA_DIRS=/usr/share/ubuntu:/usr/local/share/:/usr/share/:/var/lib/snapd/desktop ``` [1]: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html#variables Signed-off-by: Simon Deziel <simon.deziel@canonical.com> (cherry picked from commit 1c07fcf)
simondeziel
force-pushed
the
XDG-variables-5.21-candidate
branch
from
620b8e4 to
41f287e
Compare
Merged
tomponline
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.