Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-13442] Remove BAGP from the React Native CLI #2346

Merged
merged 11 commits into from
Feb 24, 2025
Merged

[PLAT-13442] Remove BAGP from the React Native CLI #2346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
950b002
Remove BAGP from RN CLI"
joshedney Feb 17, 2025
169d6ed
Remove BAGP from RN CLI
joshedney Feb 17, 2025
8a52e1d
remove gradle
joshedney Feb 18, 2025
3a207e5
Merge branch 'next' into je/plat-13442-remove-bagp-rn-cli
joshedney Feb 20, 2025
871ce44
[full ci]
joshedney Feb 20, 2025
64a29af
remove unused function
joshedney Feb 20, 2025
6cf590c
test newer versions of react native cli
joshedney Feb 20, 2025
05105be
[full ci]
joshedney Feb 20, 2025
54ddca7
reinstate full pipeline
joshedney Feb 20, 2025
38f9dba
remove gradle from react native cli
joshedney Feb 20, 2025
d530f2b
update change log for the removal of bagp
joshedney Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'next' into je/plat-13442-remove-bagp-rn-cli
  • Loading branch information
@joshedney
joshedney committed Feb 20, 2025
commit 3a207e5e54b8eeec01f1c72bff8175158fcfad32
4 changes: 2 additions & 2 deletions .buildkite/full/react-native-cli-pipeline.full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ steps:
- "bundle exec maze-runner features/build-app-tests/build-android-app.feature"
matrix:
- "0.74"
- "0.75"
retry:
automatic:
- exit_status: "*"
Expand All @@ -51,7 +50,8 @@ steps:
- "bundle install"
- "bundle exec maze-runner features/build-app-tests/build-ios-app.feature"
matrix:
- "0.74"
- "0.77"
- "0.76"
- "0.75"
retry:
automatic:
Expand Down
203 changes: 91 additions & 112 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,118 +36,97 @@ steps:
automatic:
- exit_status: "*"
limit: 1
#
# - label: ":aws-lambda: AWS Lambda tests"
# timeout_in_minutes: 35
# agents:
# queue: "macos-14"
# env:
# NODE_VERSION: "18"
# PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: "1"
# plugins:
# test-collector#v1.10.2:
# files: "test/aws-lambda/reports/TEST-*.xml"
# format: "junit"
# branch: "^main|next$$"
# api-token-env-name: "JS_AWS_LAMBDA_BUILDKITE_ANALYTICS_TOKEN"
# commands:
# # force the NPM registry as the default on CI is artifactory, which can't
# # currently install from our lockfile
# - npm ci --registry https://registry.npmjs.org
# - cd test/aws-lambda
# - bundle install
# - bundle exec maze-runner
#
# #
# # Core tests and checks
# #
# - label: ":docker: Build CI image"
# key: "ci-image"
# depends_on: "package-js"
# timeout_in_minutes: 20
# plugins:
# - artifacts#v1.5.0:
# download: min_packages.tar
# - docker-compose#v4.12.0:
# build:
# - ci
# image-repository: 855461928731.dkr.ecr.us-west-1.amazonaws.com/js
# cache-from:
# - ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base-${BRANCH_NAME}
# - ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base
# - docker-compose#v4.12.0:
# push:
# - ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base-${BRANCH_NAME}
# - ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base
# retry:
# automatic:
# - exit_status: "*"
# limit: 1
#
# - label: "Lint"
# depends_on: "ci-image"
# timeout_in_minutes: 10
# plugins:
# docker-compose#v4.12.0:
# run: ci
# command: "npm run test:lint"
#
# - label: "Unit tests"
# depends_on: "ci-image"
# timeout_in_minutes: 10
# plugins:
# docker-compose#v4.12.0:
# run: ci
# command: "npm run test:unit"
#
# - label: "Type checks/tests"
# depends_on: "ci-image"
# timeout_in_minutes: 10
# plugins:
# docker-compose#v4.12.0:
# run: ci
# command: "npm run test:types"
#
# - label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: BROWSER STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
# depends_on: "package-js"
# agents:
# queue: "macos"
# timeout_in_minutes: 5
# commands:
# - buildkite-agent pipeline upload .buildkite/basic/browser-pipeline.yml
#
# - label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: ELECTRON STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
# agents:
# queue: "macos"
# timeout_in_minutes: 5
# commands:
# - buildkite-agent pipeline upload .buildkite/basic/electron-pipeline.yml
#
# - label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: NODE STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
# depends_on: "package-js"
# agents:
# queue: "macos"
# timeout_in_minutes: 5
# commands:
# - buildkite-agent pipeline upload .buildkite/basic/node-pipeline.yml
#
# - label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: REACT NATIVE (ANDROID) STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
# depends_on:
# - "publish-js"
# agents:
# queue: "macos"
# timeout_in_minutes: 5
# commands:
# - buildkite-agent pipeline upload .buildkite/basic/react-native-android-pipeline.yml
#
# - label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: REACT NATIVE (IOS) STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
# depends_on:
# - "publish-js"
# agents:
# queue: "macos"
# timeout_in_minutes: 5
# commands:
# - buildkite-agent pipeline upload .buildkite/basic/react-native-ios-pipeline.yml

#
# Core tests and checks
#
- label: ":docker: Build CI image"
key: "ci-image"
depends_on: "package-js"
timeout_in_minutes: 20
plugins:
- artifacts#v1.5.0:
download: min_packages.tar
- docker-compose#v4.12.0:
build:
- ci
image-repository: 855461928731.dkr.ecr.us-west-1.amazonaws.com/js
cache-from:
- ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base-${BRANCH_NAME}
- ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base
- docker-compose#v4.12.0:
push:
- ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base-${BRANCH_NAME}
- ci:855461928731.dkr.ecr.us-west-1.amazonaws.com/js:ci-base
retry:
automatic:
- exit_status: "*"
limit: 1

- label: "Lint"
depends_on: "ci-image"
timeout_in_minutes: 10
plugins:
docker-compose#v4.12.0:
run: ci
command: "npm run test:lint"

- label: "Unit tests"
depends_on: "ci-image"
timeout_in_minutes: 10
plugins:
docker-compose#v4.12.0:
run: ci
command: "npm run test:unit"

- label: "Type checks/tests"
depends_on: "ci-image"
timeout_in_minutes: 10
plugins:
docker-compose#v4.12.0:
run: ci
command: "npm run test:types"

- label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: BROWSER STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
depends_on: "package-js"
agents:
queue: "macos"
timeout_in_minutes: 5
commands:
- buildkite-agent pipeline upload .buildkite/basic/browser-pipeline.yml

- label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: ELECTRON STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
agents:
queue: "macos"
timeout_in_minutes: 5
commands:
- buildkite-agent pipeline upload .buildkite/basic/electron-pipeline.yml

- label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: NODE STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
depends_on: "package-js"
agents:
queue: "macos"
timeout_in_minutes: 5
commands:
- buildkite-agent pipeline upload .buildkite/basic/node-pipeline.yml

- label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: REACT NATIVE (ANDROID) STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
depends_on:
- "publish-js"
agents:
queue: "macos"
timeout_in_minutes: 5
commands:
- buildkite-agent pipeline upload .buildkite/basic/react-native-android-pipeline.yml

- label: ":large_blue_circle: :large_blue_circle: :large_blue_circle: REACT NATIVE (IOS) STEPS :large_blue_circle: :large_blue_circle: :large_blue_circle:"
depends_on:
- "publish-js"
agents:
queue: "macos"
timeout_in_minutes: 5
commands:
- buildkite-agent pipeline upload .buildkite/basic/react-native-ios-pipeline.yml

#
# Conditionally trigger full pipeline
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.