update typicalMaximumVmNumberByteLength & update conditionals #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that in libauth v3.1.0-next.4 the function vmNumberToBigInt still has the following logic
const typicalMaximumVmNumberByteLength = 8;
where this maximum is the default for
maximumVmNumberByteLength
which then later triggers the error:@bitjson suggested setting the
typicalMaximumVmNumberByteLength
to zero to disable maximum length checksmaximumVmNumberByteLength
appears 144 times in the codebase, sometimes with custom high number value overrides for the BCH consensus for 2025.I simply updated the defaults and the three inequality checks I found, i did not dive further into the remaining occurrences.