feat(mobile): unify build settings and plugin logic for mobile and desktop #17705
+224
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sktop - Changed crate type in examples/mobile/Cargo.toml from `staticlib` to `lib`. For iOS, the `build_rust_deps.sh` script already handles building with `cargo rustc --crate-type staticlib`, so specifying `staticlib` in Cargo.toml is unnecessary. For Desktop, setting the crate type to `lib` in Cargo.toml is required for correct linking and building. - Updated examples/mobile/Makefile to call `open -a Simulator` before `xcrun simctl boot`, ensuring the Simulator.app launches correctly. - Migrated game logic in examples/mobile/src/lib.rs into a public `MainPlugin` for unified functionality. - Added examples/mobile/src/main.rs to demonstrate usage of MainPlugin on both mobile and desktop. - Added README.md with build and run instructions for Android, iOS, and Desktop.
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
- Added documentation to the mobile example's main entry point - Fixed missing_docs warning by adding an expect attribute to the MainPlugin struct
- Reformatted Android and iOS setup instructions for clarity - Added whitespace for better readability - Updated code blocks for consistency
alice-i-cecile
added
A-App
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
staticlibtolib. For iOS, thebuild_rust_deps.shscript already handles building withcargo rustc --crate-type staticlib, so specifyingstaticlibin Cargo.toml is unnecessary. For Desktop, setting the crate type tolibin Cargo.toml is required for correct linking and building.open -a Simulatorbeforexcrun simctl boot, ensuring the Simulator.app launches correctly.MainPluginfor unified functionality.