Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: make invalid_finish_reasons configurable #380

Merged

Conversation

adamoptimizer
Copy link
Contributor

@adamoptimizer adamoptimizer force-pushed the ref/invalid_finish_reasons branch from de9ab89 to 2dbcedc Compare January 19, 2025 08:47
@adamoptimizer adamoptimizer self-assigned this Jan 19, 2025
@adamoptimizer adamoptimizer marked this pull request as ready for review January 19, 2025 08:48
Copy link
Contributor

@RyanMarten RyanMarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left some comments on the logic

can take a look at the tests when they are added as well

@adamoptimizer adamoptimizer force-pushed the ref/invalid_finish_reasons branch 2 times, most recently from 078273a to 3e42d32 Compare January 21, 2025 06:37
@adamoptimizer adamoptimizer force-pushed the ref/invalid_finish_reasons branch from 3e42d32 to d410195 Compare January 21, 2025 06:39
@RyanMarten RyanMarten self-requested a review January 21, 2025 06:51
Copy link
Contributor

@RyanMarten RyanMarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RyanMarten RyanMarten merged commit 0248679 into bespokelabsai:main Jan 21, 2025
1 check passed
vutrung96 pushed a commit to vutrung96/curator that referenced this pull request Jan 21, 2025
* ref: make `invalid_finish_reasons` configurable

* test: basic invalid finish reason test
vutrung96 pushed a commit to vutrung96/curator that referenced this pull request Jan 21, 2025
* ref: make `invalid_finish_reasons` configurable

* test: basic invalid finish reason test
vutrung96 pushed a commit to vutrung96/curator that referenced this pull request Jan 21, 2025
* ref: make `invalid_finish_reasons` configurable

* test: basic invalid finish reason test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants