-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: make invalid_finish_reasons
configurable
#380
Merged
RyanMarten
merged 2 commits into
bespokelabsai:main
from
adamoptimizer:ref/invalid_finish_reasons
Jan 21, 2025
Merged
ref: make invalid_finish_reasons
configurable
#380
RyanMarten
merged 2 commits into
bespokelabsai:main
from
adamoptimizer:ref/invalid_finish_reasons
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de9ab89
to
2dbcedc
Compare
RyanMarten
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, left some comments on the logic
can take a look at the tests when they are added as well
src/bespokelabs/curator/request_processor/online/base_online_request_processor.py
Outdated
Show resolved
Hide resolved
src/bespokelabs/curator/request_processor/online/litellm_online_request_processor.py
Outdated
Show resolved
Hide resolved
078273a
to
3e42d32
Compare
3e42d32
to
d410195
Compare
RyanMarten
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
vutrung96
pushed a commit
to vutrung96/curator
that referenced
this pull request
Jan 21, 2025
* ref: make `invalid_finish_reasons` configurable * test: basic invalid finish reason test
vutrung96
pushed a commit
to vutrung96/curator
that referenced
this pull request
Jan 21, 2025
* ref: make `invalid_finish_reasons` configurable * test: basic invalid finish reason test
vutrung96
pushed a commit
to vutrung96/curator
that referenced
this pull request
Jan 21, 2025
* ref: make `invalid_finish_reasons` configurable * test: basic invalid finish reason test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#375