-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: icon view for smart playlists #114
base: main
Are you sure you want to change the base?
Conversation
Oops, I forgot... The view in the smart playlist use the new It's also only display the matching songs of an album. |
Interesting. Will this still set the queue to the full smart playlist, or just the selected album?
Need to think how to handle breaking changes like these going forward. Usually this would be via db migrations, but since the app is still in pre-release that's not strictly necessary. But I feel that a move from indexedDB to Sqlite will likely happen soon anyway. |
Also I think that the UI needs work to make sure that it all makes sense in various window sizes. Right now there is a lot of overlap when you resize the window down. So would need to answer questions like:
|
It will play the playlist on the context menu item
Tell me if I can make the changes
Yep, I forgot about that.
I will try to fix those issues in another PR |
Yeah, there's a lot of elements so we have to be opinionated about which UI elements to show when. Maybe when resizing the window to a small width (~300px), hide all panels/popups except the queue. So even if the queue is hidden, force show it. |
This PR adds:
list
by default)