-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Merge changes on main to spark workshop branch #783
Open
alanty
wants to merge
32
commits into
awslabs:spark-on-eks-workshop
Choose a base branch
from
alanty:spark-on-eks-workshop
base: spark-on-eks-workshop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Merge changes on main to spark workshop branch #783
alanty
wants to merge
32
commits into
awslabs:spark-on-eks-workshop
from
alanty:spark-on-eks-workshop
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments
…e on Graviton (awslabs#739) Reviewed-by: omrishiv <327609+omrishiv@users.noreply.github.com>
Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pulling in latest updates from main to the workshop branch and resolving merge conflicts.
Motivation
When merging
main
into the workshop branch we hit some merge conflicts (see #782).More
website/docs
orwebsite/blog
section for this featurepre-commit run -a
with this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes
This merge hasn't been tested, I've just tried to unwind the changes. I may have missed something.