fix(amazonq): check job status directly before completing #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhasani23
commented
Jan 18, 2025
| result.succeeded -> CodeModernizerJobCompletedResult.JobCompletedSuccessfully(jobId) | ||
| result.state == TransformationStatus.COMPLETED -> { | ||
| CodeModernizerJobCompletedResult.JobCompletedSuccessfully(jobId) | ||
| } |
There was a problem hiding this comment.
These in theory should be doing the same thing, but again, for consistency it makes more sense to check the final job status directly rather than this internal succeeded field.
| @@ -23,7 +23,7 @@ class CodeModernizerJobHistoryPanelTest { | |||
| tablePanelMock.updateTableData(testData) | |||
| verify(tablePanelMock, times(1)).setDefaultUI() | |||
| verify(tablePanelMock, times(1)).updateTableData(testData) | |||
| assertThat(tablePanelMock.headerLabel.text).isEqualTo("Job status") | |||
| assertThat(tablePanelMock.headerLabel.text).isEqualTo("Transformation status") | |||
There was a problem hiding this comment.
Is it possible to use codemodernizer.toolwindow.job_status.header here instead of hardcoding the string?
ntarakad-aws
approved these changes
Jan 21, 2025
samgst-amazon
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Not exactly a bug, but to be safe, better to check the job status directly as being
COMPLETEDbefore showing users the option to download results, which is consistent with how we handle the cases ofPARTIALLY_COMPLETED,FAILED, etc.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.