fix(textarea): autoresize textarea resets when value is empty #6031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 993caf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
calebpollman
previously approved these changes
Nov 8, 2024
![github-advanced-security[bot]](/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/react/src/primitives/TextArea/__tests__/useAutoresizeTextarea.test.ts
Fixed
Show fixed
Hide fixed
packages/react/src/primitives/TextArea/__tests__/useAutoresizeTextarea.test.ts
Fixed
Show fixed
Hide fixed
dbanksdesign
commented
Nov 9, 2024
| @@ -7,7 +7,7 @@ export const useAutoresizeTextArea = ( | |||
| ): void => { | |||
| useEffect(() => { | |||
| const resizeTextArea = () => { | |||
| if (textAreaRef && value) { | |||
| if (textAreaRef) { | |||
There was a problem hiding this comment.
The bug was we were using value in the conditional here, value could be falsey and we still want to re-trigger the effect. So value is in the dependency array, but removing it from here to fix the bug
calebpollman
approved these changes
Nov 9, 2024
dindjarinjs
approved these changes
Nov 10, 2024
This was referenced Nov 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.