Skip to content

breaking: updating tabs #4509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 26, 2023
Merged

breaking: updating tabs #4509

merged 25 commits into from
Oct 26, 2023

Conversation

dbanksdesign
Copy link
Contributor

@dbanksdesign dbanksdesign commented Oct 4, 2023

Description of changes

Huge refactor of Tabs component.

  • Removing Radix tabs
  • Fully composable
  • Proper BEM classes

A lot of the changes are updating our own usage of Tabs in the docs

Issue #, if available

#2553
#4191

Description of how you validated changes

https://next-release-tabs.d32sljejpnv3v5.amplifyapp.com/

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: e613593

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@aws-amplify/ui-react Major
@aws-amplify/ui Major
@aws-amplify/ui-react-auth Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react-core-auth Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-native-auth Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dbanksdesign dbanksdesign temporarily deployed to ci October 16, 2023 03:35 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 16, 2023 03:35 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 16, 2023 03:35 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign marked this pull request as ready for review October 16, 2023 23:52
@dbanksdesign dbanksdesign requested a review from a team as a code owner October 16, 2023 23:52
@dbanksdesign dbanksdesign temporarily deployed to ci October 24, 2023 22:02 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 24, 2023 22:02 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 24, 2023 22:02 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 03:58 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 03:58 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 03:58 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 03:58 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 05:39 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 05:39 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 05:40 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 05:40 — with GitHub Actions Inactive
Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 17:52 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 17:52 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 17:52 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci October 25, 2023 17:52 — with GitHub Actions Inactive
@reesscot reesscot merged commit 55d1f49 into next-release/main Oct 26, 2023
@reesscot reesscot deleted the next-release/tabs branch October 26, 2023 08:11
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants