feat(storage-manager): add metadata #3788
Conversation
🦋 Changeset detectedLatest commit: 548b05b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
docs/src/pages/[platform]/connected-components/storage/storagemanager/props.ts
Outdated
Show resolved
Hide resolved
examples/next/pages/ui/components/storage/storage-manager/metadata/index.page.tsx
Outdated
Show resolved
Hide resolved
| @@ -32,6 +32,12 @@ export type StorageFiles = StorageFile[]; | |||
|
|
|||
| export type DefaultFile = Pick<StorageFile, 'key'>; | |||
|
|
|||
| type ProcessFileProps = Required<Pick<StorageFile, 'file' | 'key'>> & { | |||
There was a problem hiding this comment.
Prefer Props for component props, Params for function params
packages/react-storage/src/components/StorageManager/utils/uploadFile.ts
Outdated
Show resolved
Hide resolved
| @@ -12,7 +12,8 @@ type BaseDropZoneTokens<OutputType> = DesignTokenProperties< | |||
|
|
|||
| export interface FileUploaderTokens<OutputType extends OutputVariantKey> { | |||
| dropzone?: DesignTokenProperties< | |||
| 'gap' | 'paddingBlock' | 'paddingInline' | 'textAlign' | |||
| 'gap' | 'paddingBlock' | 'paddingInline' | 'textAlign', | |||
| OutputType | |||
There was a problem hiding this comment.
Note: this is a bug because with the 2nd arg all these properties become required
There was a problem hiding this comment.
Did you already fix this in StorageManager, or did you mean to fix this in FileUploader?
There was a problem hiding this comment.
StorageManger basically just extends this type so it is fixed in both :)
There was a problem hiding this comment.
So do we need to rename this type? When we delete the FileUploader tokens in next release, won't StorageManager break?
There was a problem hiding this comment.
When we do that breaking change we will inline that type into the storagemanager type
docs/src/pages/[platform]/connected-components/storage/storagemanager/props.ts
Outdated
Show resolved
Hide resolved
packages/react-storage/src/components/StorageManager/utils/uploadFile.ts
Outdated
Show resolved
Hide resolved
packages/react-storage/src/components/StorageManager/utils/uploadFile.ts
Outdated
Show resolved
Hide resolved
packages/react-storage/src/components/StorageManager/utils/uploadFile.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Caleb Pollman <cpollman@amazon.com>
…manager/props.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com>
…oadFile.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com>
…oadFile.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com>
…oadFile.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com>
| @@ -32,6 +32,12 @@ export type StorageFiles = StorageFile[]; | |||
|
|
|||
| export type DefaultFile = Pick<StorageFile, 'key'>; | |||
|
|
|||
| type ProcessFileParams = Required<Pick<StorageFile, 'file' | 'key'>>; | |||
|
|
|||
| type ProcessFile = ( | |||
There was a problem hiding this comment.
I don't know the answer, but will this be exported since the interface below is exported?
packages/react-storage/src/components/StorageManager/hooks/useUploadFiles/useUploadFiles.ts
Outdated
Show resolved
Hide resolved
Description of changes
Adding
metadataprop to StorageManager and to theprocessFilefunction so users can add metadata per-session and per-file.Issue #, if available
#3683
Description of how you validated changes
Added an example
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.